[Mpi3-tools] New MPIT draft and next TelCon

[Dave Goodell]

My comments so far:

section 1.2.2: can we cut "MPI_" from all of the "MPIT_MPI_RESOURCE_TYPE_BLAH" constants and related functions?  These names seem unnecessarily wordy.

page 4: MPIT_MPI_RESOURCE_COMMUNICATOR takes an MPI_Comm as an IN parameter, but the binding has a pointer as the type.  Same goes for all of the other similar functions on this page.

page 4, line 33: "MPI_" should be "MPI_Group"

page 5, line 29: "MPIT_MPI_Resource*" seems to be in the wrong typeface.  This is a C language type, so it should be typewriter text.

General comment about this section and functionality:  Since we assume only C bindings, can we just replace all of these functions with a single function?  Something like:

MPIT_Get_resource(void *handle_ptr, int resource_type, MPIT_MPI_Resource *out_resource);

and a call to it would look something like this:
-----8<----
int type;
int index = 0;
MPIT_MPI_Resource resource;
MPIT_Controlvar_handle handle;
MPI_Comm comm = MPI_COMM_SELF;
MPIT_Controlvar_get_info(index, ..., &type, ...);
if (type == MPIT_MPI_RESOURCE_TYPE_COMMUNICATOR) {
    MPIT_Get_resource(&comm, type, &resource);
    MPIT_Controlvar_handle_allocate(index, resource, &handle);
    /* read, write, etc here using handle */
}
-----8<----

I think the string arguments section (1.2.3) could use just a little polishing to make its behavior crystal clear, but it's much better than it was.  Also, "deposits"-->"writes".

I'll admit I didn't have time to thoroughly read the perfvar section, so there might still be issues there.

As for the category section, it looks basically OK to me.  I thought that we decided at the last call that categories would be flat and wouldn't contain other categories.  If you insist on pursuing this approach further, you'll need more text to explain that categories can't contain each other or themselves cyclically.

A general language comment: you should basically do a search and replace of "have to" or "has to" with "must" throughout the document.

-Dave

On Jan 4, 2011, at 3:35 AM CST, Martin Schulz wrote:

> Hi all,
> 
> Happy new year!
> 
> This is just a quick reminder that we have the next MPI-3 tools
> TelCon scheduled for next Monday 1/10/11 at 8am PT, 11am
> ET, 5pm MEZ. The main point on the agenda is to continue
> going through the MPIT document.
> 
> I habe uploaded a new version of the MPIT draft (with changebars
> compared to the December version) to the MPI-3 tools WG Wiki at
> 
> https://svn.mpi-forum.org/trac/mpi-forum-web/attachment/wiki/MPI3Tools/mpit/
> 
> It (hopefully) contains all change requests - if I forgot something,
> please let me know. The document should be now more or less
> complete - I updated also the performance variable section and
> the categories (Dave, I adjusted this to match the rest of the
> document - could you please check this over if this matches with
> what you remember from the discussion last month?).
> 
> The main open issue is the addition of examples, which I'll do
> as soon as I get to it. Any suggestions for this are welcome.
> Also the error/return code table at the end probably needs 
> some entries to be complete.
> 
> The document purposely does not contain the PMPI section of
> the tools chapter, yet, since this currently still the old version and
> also causes some strange Latex error caused by the change
> bar macros. If anyone knows how to fix this, that would be great
> (the macros also still add some arbitrary spaces, which I don't
> know how to remove - anyone any ideas?). I will update this
> once we have a new golden copy of the PMPI part with the
> currently proposed updates.
> 
> Please let me know if you have any comments on the new
> draft or see anything missing.
> 
> Thanks!
> 
> Martin
> 
> 
> 
> 
> ________________________________________________________________________
> Martin Schulz, schulzm at llnl.gov, http://people.llnl.gov/schulzm
> CASC @ Lawrence Livermore National Laboratory, Livermore, USA
> 
> 
> 
> _______________________________________________
> Mpi3-tools mailing list
> Mpi3-tools at lists.mpi-forum.org
> http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi3-tools