[Mpi3-rma] current version of proposal

[Rajeev Thakur]

My comments on the current draft:

5:16 - "void **base" should be "void *baseptr". (void * is used in Alloc_mem)

5:28 - What discussion of alloc_mem in Section 8.2 also applies here? Is it the Rationale on the next page after free_mem? That should be mentioned here. It is important to mention here that void* actually means void**.

6:11 - Change "This is combined with local routines" to "It must be used in combination with local routines (MPI_Win_attach and MPI_Win_detach)"

7:19 - Awkward sentence. Change to "The memory region specified must not contain any part that is already attached to the window win." Delete the part starting from "that is"

19:7 - "each buffer entry" -> "each entry in origin buffer"
19:12 - "each buffer entry" -> "each entry in result buffer"
19:19 - "each buffer entry" -> "each entry in target buffer"

19:27 -  delete * in "int *target_count"

19:37 - "datatype of" should be "origin_datatype from"

20:23 - "the buffer entry" -> "the entry in origin, result, and target buffers"

20:42 - "datatype of" -> "datatype from"

20:46 - awkward sentence. Change "and MPI_NO_OP or MPI_REPLACE" to "as well as MPI_NO_OP and MPI_REPLACE," (add comma at the end)

21:13 - "of buffer entry" -> "of the element in all buffers"

21:33 - "target compare buffer" -> "target buffer"

21:34 - change to "must belong to one of the following categories of predefined datatypes"

22:42 - after "operation" add "(i.e., after the corresponding test or wait)"

25:28 - delete * in "int *target_count"

26:43 - Labeling problem: Figure 11.5 should be Figure 11.1

26:12 - Delete the sentences from "This query functionality" onwards. There is no way to request a memory model, only to query it. So no similarity with threads.

29:43 - These two calls -> These four calls. Add sentence to cover lock_all and unlock_all

31:35 - comma after "needed". Delete then
31:36   - make it compare-and-swap

37:11 - Awkward sentence. Change to "During the epoch, the calling process can access the window memory on all processes in win by using RMA operations."

37:14 - "refers to all" -> "refers to a lock on all"

39:20 - awkward sentence. Change to "MPI_WIN_FLUSH completes all outstanding RMA operations initiated by the calling process to the target rank. The operations are completed both at the origin and at the target." Delete sentence "RMA operations..."

40:1 - Sentence style is different from previous functions. Change to "Locally completes at the origin all..."

46:9 - Delete the part "when the RMA operation completes at the target". This Rule 5 is about when a local update is visible in the public window. It has nothing to do with RMA operation completing at target.

47:14 - I would say delete this advice to implementors. If we keep it, I would like to fix the first sentence, which is awkward.

47:28 - why is "that use the same operation" being removed. It should be there.

47:42 - "based on avoiding" -> "to avoid"

47:47 - "at the target" sounds like you are referring to another process, whereas you are referring to this process. Just delete it.

48:1 - Remember to update Item 1 on previous page depending on the outcome of this. Right now it contradicts Item 1.

49:18 - or unlock_all

50:1, Example 11.12 - Lock_all and unlock_all are not collective. They are not needed on process B. Also, I would prefer the barrier to be before local_all on process A.

50:2: Delete "Process B only needs to call lock_all..."

51:1, Example 11.14: Same. Process B does not need to call lock_all, unlock_all. I would prefer the unlock_all on process A to be before the barrier.




Typos/small fixes
-------------
1:39 - "in the following" -> "in this chapter"
1:47 - add comma before "which"
3:37 - delete "then"
3:45 - add comma after "libraries". Delete "then"
3:47 - add comma before "which"
5:27 - "valid," -> "valid;"
6:34 - "target. I.e," -> "target; i.e.,"
7:41 - why is "vendor" in green, should just be deleted
7:43 - "MPI; that" -> "MPI, which"
7:46 - "in" -> "on"
7:47 - "that" -> "the"
8:45 - "memory," -> "memory;"
9:2   - "This, to" -> "This is to"
9:5   - after "argument" add "to the corresponding window creation function"
9:22 - delete first word "in"
10:32 - "MPI wait" -> "MPI test or wait"
19:34 - add space between last two variables
21:2 - why is functionality in green. delete it.
26:20 - "is" should be "are" 
26:21 - which -> that
37:10 - delete green text
38:4 - E.g. -> For example   (a sentence shouldn't begin with E.g. or I.e.)
38:25 - Delete "might". Should not be in green.
39:2 - I prefer the MPI 2.2 version because "The update..." applies only to the last of the 3 options in the previous sentence.
39:23 and 25 - delete green stuff; it wasn't in 2.2.
39:24 - "document, this" -> "document, which"
44:41 - Windows -> windows
46:27 - add comma after "call"
49:31 - "is" -> "are"
50:20 - "reading a" -> "reading of a"
51:18 - proces -> process
52:25 - interation -> interaction
54:48 - add comma before which