[Mpi-forum] make check is busted!

[William Gropp]

Fab,

Yes, make check should build cleanly.  For example, the errors in coll.tex are Fortran 90 subroutines, listed as complete routines, that are missing the required "END" statement.  There are also "naked" examples that don't have the proper annotations; these should be added.  

For those that don't know about the "make check" option - this makes sure that our examples don't have simple errors in them - it requires a small amount of work to add the necessary annotations (documented and examples exist throughout the source) and our experience has been that this catches a lot of errors that would otherwise be missed.  In looking over the make check output, I see quite a few of those.  Chapter authors should check their chapters.

Bill

On Jan 30, 2012, at 4:07 PM, Fab Tillier wrote:

> Hey Folks,
> 
> Is it reasonable for me to expect that building the examples in the standard wouldn't generate a bunch of errors?  Do we build the examples before publishing drafts, etc?
> 
> Just running 'make check' on the approved/MPI-3.0 branch gives me a bunch of errors, in the following files:
> - chap-one-side/one-side-2.tex
> - chap-context/context.tex
> - chap-coll/coll.tex
> - chap-binding/binding-2.tex
> - chap-topol/topol.tex
> - chap-prof/prof.tex
> 
> Can the chapter owners figure out how to either fix or suppress these errors?  It makes it really hard to find errors I may have introduced - the signal to noise ratio is really lousy.  Alternatively, is there a 'correct' way of running 'make check' that won't generate these?  I ran autoconf in mpicompilechk, then configure.  Should I be specifying extra parameters or anything?
> 
> Thanks,
> -Fab
> 
> 
> _______________________________________________
> mpi-forum mailing list
> mpi-forum at lists.mpi-forum.org
> http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi-forum

William Gropp
Director, Parallel Computing Institute
Deputy Director for Research
Institute for Advanced Computing Applications and Technologies
Paul and Cynthia Saylor Professor of Computer Science
University of Illinois Urbana-Champaign