[Mpi3-tools] MPI handles interface

Ashley Pittman ashley at pittman.co.uk
Tue Apr 21 04:56:26 CDT 2009

On Thu, 2009-04-16 at 17:31 -0400, Jeff Squyres wrote:
> What about enums -- will those be problematic?  I tended to prefer  
> enums in most places (vs. #define's) because a debugger can show those  
> value names (when debugging this software itself -- not necessarily  
> when in general use by a debugger for an MPI job).  If enums are going  
> to be problematic, I can switch to #defines -- but it would be nice  
> not to, if possible.

For reference the original code uses enums.

> The communicator "query" functions that I created start around line 649:
>      http://www.open-mpi.org/hg/hgwebdir.cgi/jsquyres/mpi3-tools-handles/file/4c5c1e7c0ef1/ompi/debuggers/mpihandles_interface.h#l649
> Could I get some comments on the group as to the general style of what  
> I did?

The general style looks OK to me, without digging too far however I'm
concerned about the idea of the DLL allocating memory and then having
the debugger free it, this seems like a recipe for disaster to me.

I should be in the TelCon later all being well.

Ashley Pittman.

More information about the mpiwg-tools mailing list