[Mpi-forum] MPI-3: MPI_T_... names
Adam T. Moody
moody20 at llnl.gov
Wed Jul 25 11:59:07 CDT 2012
The name changes look good to me. I remember that we initially
contracted names due to the 31 character limit on MPI symbols, but it
looks like all of these fit within that limit. It is certainly easier
to read with the new expanded names.
-Adam
Kathryn Mohror wrote:
>I also agree to the name changes.
>
>Kathryn
>
>On 7/25/2012 2:59 AM, Bronis R. de Supinski wrote:
>
>
>>OK.
>>
>>On Wed, 25 Jul 2012, Rolf Rabenseifner wrote:
>>
>>
>>
>>>After no objection by the tools chapter committee,
>>>I would change everywhere (tools + appLang) in one svn step:
>>>
>>>- from old
>>> MPI_T_ERR_CANNOTINIT
>>> MPI_T_ERR_NOTINITIALIZED
>>> MPI_T_ERR_MEMORY
>>> MPI_T_ERR_CVAR_SETNOTNOW
>>> MPI_T_ERR_CVAR_SETNEVER
>>> MPI_T_ERR_PVAR_NOWRITE
>>> MPI_T_ERR_PVAR_NOSTARTSTOP
>>> MPI_T_ERR_PVAR_NOATOMIC
>>> MPI_T_ERR_INVALIDINDEX
>>> MPI_T_ERR_INVALIDITEM
>>> MPI_T_ERR_INVALIDSESSION
>>> MPI_T_ERR_INVALIDHANDLE
>>> MPI_T_ERR_OUTOFHANDLES
>>> MPI_T_ERR_OUTOFSESSIONS
>>> to new
>>> MPI_T_ERR_CANNOT_INIT
>>> MPI_T_ERR_NOT_INITIALIZED
>>> MPI_T_ERR_MEMORY (unchanged)
>>> MPI_T_ERR_CVAR_SET_NOT_NOW
>>> MPI_T_ERR_CVAR_SET_NEVER
>>> MPI_T_ERR_PVAR_NO_WRITE
>>> MPI_T_ERR_PVAR_NO_STARTSTOP
>>> MPI_T_ERR_PVAR_NO_ATOMIC
>>> MPI_T_ERR_INVALID_INDEX
>>> MPI_T_ERR_INVALID_ITEM
>>> MPI_T_ERR_INVALID_SESSION
>>> MPI_T_ERR_INVALID_HANDLE
>>> MPI_T_ERR_OUT_OF_HANDLES
>>> MPI_T_ERR_OUT_OF_SESSIONS
>>>
>>>Best regards
>>>Rolf
>>>
>>>----- Original Message -----
>>>
>>>
>>>>From: "Bronis R. de Supinski" <bronis at llnl.gov>
>>>>To: "Main MPI Forum mailing list" <mpi-forum at lists.mpi-forum.org>
>>>>Sent: Tuesday, July 24, 2012 1:03:07 PM
>>>>Subject: Re: [Mpi-forum] MPI-3: MPI_T_... names
>>>>I have no strong opinion on this issue.
>>>>
>>>>On Tue, 24 Jul 2012, Rolf Rabenseifner wrote:
>>>>
>>>>
>>>>
>>>>>I started a new email-trunk, because this mail is mainly about
>>>>>names.
>>>>>
>>>>>The problem with MPI_T_... names is that they are partially
>>>>>very long:
>>>>>
>>>>>Current longest MPI_T constants:
>>>>>
>>>>>123456789012345678901234567890
>>>>>MPI_T_PVAR_CLASS_HIGHWATERMARK (30)
>>>>>MPI_T_PVAR_CLASS_LOWWATERMARK (29)
>>>>>MPI_T_VERBOSITY_MPIDEV_DETAIL (29)
>>>>>
>>>>>The system is classes of constants are named with underscores,
>>>>>e.g. MPI_T_PVAR_CLASS, the end-names without underscores,
>>>>>e.g. HIGHWATERMARK.
>>>>>
>>>>>In the error codes, your right, they
>>>>>- should change from
>>>>> MPI_T_ERR_INVALIDINDEX
>>>>> MPI_T_ERR_INVALIDITEM
>>>>> MPI_T_ERR_INVALIDSESSION
>>>>> MPI_T_ERR_INVALIDHANDLE
>>>>> to
>>>>> MPI_T_ERR_INVALID_INDEX
>>>>> MPI_T_ERR_INVALID_ITEM
>>>>> 123456789012345678901234567890
>>>>> MPI_T_ERR_INVALID_SESSION (25)
>>>>> MPI_T_ERR_INVALID_HANDLE
>>>>> because the class name is MPI_T_ERR_INVALID_
>>>>>
>>>>>- and also
>>>>> MPI_T_ERR_OUTOFHANDLES
>>>>> MPI_T_ERR_OUTOFSESSIONS
>>>>> to
>>>>> MPI_T_ERR_OUT_OF_HANDLES
>>>>> MPI_T_ERR_OUT_OF_SESSIONS
>>>>>- and they may change
>>>>> MPI_T_ERR_CANNOTINIT
>>>>> MPI_T_ERR_NOTINITIALIZED
>>>>> MPI_T_ERR_MEMORY
>>>>> MPI_T_ERR_CVAR_SETNOTNOW
>>>>> MPI_T_ERR_CVAR_SETNEVER
>>>>> MPI_T_ERR_PVAR_NOWRITE
>>>>> MPI_T_ERR_PVAR_NOSTARTSTOP
>>>>> MPI_T_ERR_PVAR_NOATOMIC
>>>>> to
>>>>> MPI_T_ERR_CANNOT_INIT
>>>>> MPI_T_ERR_NOT_INITIALIZED
>>>>> MPI_T_ERR_MEMORY
>>>>> MPI_T_ERR_CVAR_SET_NOT_NOW
>>>>> MPI_T_ERR_CVAR_SET_NEVER
>>>>> MPI_T_ERR_PVAR_NO_WRITE
>>>>> 123456789012345678901234567890
>>>>> MPI_T_ERR_PVAR_NO_STARTSTOP (27)
>>>>> MPI_T_ERR_PVAR_NO_ATOMIC
>>>>>
>>>>>All the other MPI_T_... names seem to be fine.
>>>>>
>>>>>Bets regards
>>>>>Rolf
>>>>>
>>>>>----- Original Message -----
>>>>>
>>>>>
>>>>>>From: "Alexander Supalov" <alexander.supalov at intel.com>
>>>>>>To: "Martin Schulz" <schulzm at llnl.gov>, "Main MPI Forum mailing
>>>>>>list" <mpi-forum at lists.mpi-forum.org>
>>>>>>Sent: Tuesday, July 24, 2012 9:35:13 AM
>>>>>>Subject: Re: [Mpi-forum] MPI-3: MPI_T_ERR_... and MPI_ERR_LASTCODE
>>>>>>Hi everybody,
>>>>>>
>>>>>>I see that that my innocent remarks re. Annex A have lead to a lot
>>>>>>of
>>>>>>discussion. What I'm going to say may resemble Bart Simpson's "I
>>>>>>didn't do it", but I think I have to:
>>>>>>
>>>>>>When commenting on the MPI_T_* names, I meant only their
>>>>>>composition
>>>>>>that differed from most other comparable MPI constant names in that
>>>>>>it
>>>>>>was 1) using contractions and 2) not using underscores to separate
>>>>>>different words. The MPI_T_CANTINIT was but one example of this. I
>>>>>>proposed to change all MPI_T_* names to follow the more traditional
>>>>>>rules (i.e., 1) do not use contractions and 2) do use underscores),
>>>>>>which lead to the MPI_T_CANNOT_INIT proposal that should be
>>>>>>consistently followed up on for every other MPI_T_* name. The
>>>>>>MPI_ERR_LASTCODE was mentioned as a counterexample of a known MPI
>>>>>>constant name that was not following this set of rules either. Oh
>>>>>>well, this is an old one and we won't change it. At no time did I
>>>>>>intend the MPI_T series to become a part of the MPI_ERR series,
>>>>>>although I must admit that they look really close when you start
>>>>>>thinking about them. We will probably have enough time for this
>>>>>>contemplation in the MPI 3.1 time frame.
>>>>>>
>>>>>>To sum up, my proposal now is:
>>>>>>
>>>>>>1) Consider replacing contractions in all MPI_T_* names
>>>>>>2) Consider using underscores in all MPI_T_* names
>>>>>>3) Drop the MPI_ERR and MPI_T connection idea
>>>>>>
>>>>>>And if 1) and 2) are considered too invasive at this point, I won't
>>>>>>go
>>>>>>nuts either: after all, these are just constant names.
>>>>>>
>>>>>>Best regards.
>>>>>>
>>>>>>Alexander
>>>>>>
>>>>>>
>>>>>--
>>>>>Dr. Rolf Rabenseifner . . . . . . . . . .. email
>>>>>rabenseifner at hlrs.de
>>>>>High Performance Computing Center (HLRS) . phone
>>>>>++49(0)711/685-65530
>>>>>University of Stuttgart . . . . . . . . .. fax ++49(0)711 /
>>>>>685-65832
>>>>>Head of Dpmt Parallel Computing . . .
>>>>>www.hlrs.de/people/rabenseifner
>>>>>Nobelstr. 19, D-70550 Stuttgart, Germany . (Office: Allmandring 30)
>>>>>_______________________________________________
>>>>>mpi-forum mailing list
>>>>>mpi-forum at lists.mpi-forum.org
>>>>>http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi-forum
>>>>>
>>>>>
>>>>>
>>>>_______________________________________________
>>>>mpi-forum mailing list
>>>>mpi-forum at lists.mpi-forum.org
>>>>http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi-forum
>>>>
>>>>
>>>--
>>>Dr. Rolf Rabenseifner . . . . . . . . . .. email rabenseifner at hlrs.de
>>>High Performance Computing Center (HLRS) . phone ++49(0)711/685-65530
>>>University of Stuttgart . . . . . . . . .. fax ++49(0)711 / 685-65832
>>>Head of Dpmt Parallel Computing . . . www.hlrs.de/people/rabenseifner
>>>Nobelstr. 19, D-70550 Stuttgart, Germany . (Office: Allmandring 30)
>>>
>>>
>>>
>>_______________________________________________
>>mpi-forum mailing list
>>mpi-forum at lists.mpi-forum.org
>>http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi-forum
>>
>>
>>
>
>_____________________________________________________________________
>Kathryn Mohror, kathryn at llnl.gov, http://people.llnl.gov/mohror1
>CASC @ Lawrence Livermore National Laboratory, Livermore, CA, USA
>
>
>_______________________________________________
>mpi-forum mailing list
>mpi-forum at lists.mpi-forum.org
>http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi-forum
>
>
More information about the mpi-forum
mailing list