[Mpi-21] AUTHORS+REVIEWERS - Draft Apr. 12, 2008
Rolf Rabenseifner
rabenseifner at [hidden]
Mon Apr 14 01:45:45 CDT 2008
All authors, Adam and Torsten,
all authors have their write-token to their chapter.
This week, they still should correct small things and should
switch the __ in the form to DON2.
On Friday 18, I'll take back the write-token witout any further
announcment and will produce the final version of MPI-2.1
that will go into "official reading".
I.e., until this Thursday, April 17, all **authors** should fix
what they can and what reviewers report.
I will not fix any further bug. The responsibility is at the chapters
authors.
Best regards
Rolf
On Sun, 13 Apr 2008 14:35:51 -0400
Torsten Hoefler <htor_at_[hidden]> wrote:
> Hi Rolf, Adam,
> I understand from your mail Rolf, that Adam lost his write token and
> that only you can apply the changes/comments to the chapter (in my case
> the collectives chapter). Thus, I'll send my review results to the list
> instead the chapter author directly. My general comment: very well done
> Adam :).
>
> I have some smaller editing remarks and also found some small errors and
> clarification possibilities (see below).
>
> > ----------------------------------------------------------------------------------
> > 1234567890123456789012345678901234567890123456789012345678901234567890123456789012
> > All references are based on MPI-2.1 Draft Apr. 12, 2008
> > ww.a __ pnnn.ll text (with nnn=page number and ll=line number
> > text continued
> > ...
> > ww.b __ pnnn.ll text ... and so on (total line length <= 82 characters.)
> > ----------------------------------------------------------------------------------
> Ok, here my remarks, many of them (especially EDIT or CLAR) can probably
> be ignored, but I thought I'd bring it up:
>
> general: the line numbers are completely out of sync ... it's hard to
> classify a line that is between two line numbers.
>
> 5.a EDIT p129.19-41 "all group members" vs. "all members of a group"
> should use the same phrasing (parallel structure)
> 5.b NICE p129.41 Reference to 5.11 not 5.11.1
> 5.c EDIT p129.45 remove "," (comma)
> 5.d EDIT p129.43 replace "the same" with "a"
> 5.e EDIT p129.45 "the same group" in line 43 conflicts with "group or
> groups"
> 5.f CLAR p131.1 add "with exceptions stated in the following" to first
> sentence
> 5.g EDIT p131.4 no linebreak (Chapter~\ref{...})
> 5.h ERR p131.31 replace "will" with "might"
> 5.i ERR p132. "special communicator must be created" this is wrong,
> later (in the bcast section) it is stated differently
> ... I would just remove this part of the advice or say
> "might be created" (see Bcast advice)
> 5.j CLAR p131.37 add "depending on the operation performed after last
> sentence (right now it sounds like ths user is free to
> choose which argument to replace)
> 5.k EDIT p133.32 "a" -> "an"?
> 5.l EDIT p136.22 start sentence with "If the communicator is an
> intracommunicator" as for all the other operations,
> remove "for intracommunicators" in line 23
> 5.m EDIT p136.24 replace "," by "and"
> 5.n EDIT p136.26-31 this paragraph is redundant (it's all already stated
> earlier, do we want this redundancy in the standard?)
> 5.o EDIT p136.32 move sentence to end of the previous paragraph (line
> 25)
> 5.p EDIT p136.37 "data is braodcasted" (not braodcast)
> 5.q CLAR p136.38-39 the text talks about send and receive buffer argument,
> but bcast only has a single buffer argument ...
> 5.r CLAR p136.38 "must be consistent with the ..." what does the word
> consistent mean in this context? This seems undefined.
> I think it means that the signature (size, count) is
> the same. We should say this explicitely. The same
> term "consistent" is used in all following operations
> (I'm not going to add it again)
> 5.s EDIT p138.3 write "all processes" instead of "process i" (i is
> never defined)
> 5.t ERR p139.47 data is not necessarily placed in rank order. The
> order is freely definably by the user in the displs[]
> array. Or does the standard enforce the displs[] array
> to preserve order? We might want to run this through
> the forum (or just ignore it?)?
> 5.u CLAR p136.42 add "The examples in this section are using
> intracommunicators." as in p140.27
> 5.v EDIT p147.48 the last paragraph is redundant (has been stated
> before for all collectives)
> 5.w EDIT p157.35 why a separate subsection for Alltoallw but not for
> Alltoallv? I'd remove this subsection
> 5.x EDIT p157.36 the first two sentences should go to rationale (we
> don't need to rationalize the operation in the
> description)
> 5.y EDIT p161.13 replace "Reduce" by "Reduction" or "Operations for
> MPI_Reduce"
> 5.z EDIT p162.13 state that the example is in Fortran (it's said for
> all the C examples before)
> 5.aa EDIT p163.10-12 I think we don't need to backref to MPI-1 here if we
> consider MPI-2.1 a complete standard.
> 5.ab CLAR p163.20 replace "bit" by "numeric" or "integer"
> 5.ac EDIT p167.41 doubled sentence "The order of ..."
> 5.ad CLAR p169.2 add: (without supporting the "in place" option)
> 5.ae ERR p169.16-20 the example will deadlock if root == groupsize-1. Has
> been there for a while :). Use Irecv/Wait instead.
> 5.af EDIT p171.48 state that example is in Fortran
> 5.ag ERR p174.12-20 this rationale should be erased completely because it
> explains (for MPI-1), why only the inclusive is supported ;-)
> 5.ah ERR p175.20 erase the last sentence in rationale, we don't need
> this anymore (is MPI-1)
> 5.ai EDIT p177.48 move orphaned Example header to next page (might
> change after edits though -> check chapter for orphans)
> 5.aj EDIT p179.24 the font suddenly changes? (sans-serif)
> 5.ak CLAR p179.27 maybe we should add: "and to ensure appropriate
> matching (for deterministic behavior)
>
> Best,
> Torsten
>
> --
> bash$ :(){ :|:&};: --------------------- http://www.unixer.de/ -----
> Indiana University | http://www.indiana.edu
> Open Systems Lab | http://osl.iu.edu/
> 150 S. Woodlawn Ave. | Bloomington, IN, 474045-7104 | USA
> Lindley Hall Room 135 | +01 (812) 855-3608
> _______________________________________________
> mpi-21 mailing list
> mpi-21_at_[hidden]
> http://lists.mpi-forum.org/mailman/listinfo.cgi/mpi-21
Dr. Rolf Rabenseifner . . . . . . . . . .. email rabenseifner_at_[hidden]
High Performance Computing Center (HLRS) . phone ++49(0)711/685-65530
University of Stuttgart . . . . . . . . .. fax ++49(0)711 / 685-65832
Head of Dpmt Parallel Computing . . . www.hlrs.de/people/rabenseifner
Nobelstr. 19, D-70550 Stuttgart, Germany . (Office: Allmandring 30)
More information about the Mpi-21
mailing list